doc: support toolchain Visual Studio 2022 & 2026 + Windows 10 & 11 SDK#61864
Open
MikeMcC399 wants to merge 2 commits intonodejs:mainfrom
Open
doc: support toolchain Visual Studio 2022 & 2026 + Windows 10 & 11 SDK#61864MikeMcC399 wants to merge 2 commits intonodejs:mainfrom
MikeMcC399 wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
cjihrig
approved these changes
Feb 17, 2026
This comment was marked as resolved.
This comment was marked as resolved.
lpinca
approved these changes
Feb 17, 2026
StefanStojanovic
approved these changes
Feb 18, 2026
legendecas
reviewed
Feb 18, 2026
MikeMcC399
changed the title
Contributor
Author
|
For the Windows SDK: Note that the Windows 10 SDK (10.0.19041.0) is out of support since 2025-10-14.
The Windows 11 SDK "can target Windows 11, version 25H2, in addition to previous Windows releases." Windows 10 SDK should be removed from the Node.js supported toolchain in a separate semver-major PR. (Deadline 2026-03-22 for 26.x) |
legendecas
approved these changes
Feb 19, 2026
legendecas
added
windows
Contributor
Author
|
If this could now go to the
commit-queue
I would need to have this one landed first though. |
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61864 ✔ Done loading data for nodejs/node/pull/61864 ----------------------------------- PR info ------------------------------------ Title doc: support toolchain Visual Studio 2022 & 2026 + Windows 10 & 11 SDK (#61864) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MikeMcC399:windows-supported-toolchain -> nodejs:main Labels doc, windows, build, author ready Commits 2 - doc: support toolchain Visual Studio 2022 & 2026 + Windows 11 SDK - add back Windows 10 SDK Committers 1 - Mike McCready <66998419+MikeMcC399@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/61864 Refs: https://github.com/nodejs/node/issues/61449 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61864 Refs: https://github.com/nodejs/node/issues/61449 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 17 Feb 2026 11:04:03 GMT ✔ Approvals: 4 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61864#pullrequestreview-3813779423 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61864#pullrequestreview-3816073746 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/61864#pullrequestreview-3818866791 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61864#pullrequestreview-3828037392 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 90c6dfbbce..ca92ea03da main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 70dff3d287 doc: clarify status of feature request issues - ca92ea03da doc: clarify status of feature request issues -------------------------------------------------------------------------------- HEAD is now at ca92ea03da doc: clarify status of feature request issues ✔ Reset to origin/main - Downloading patch for 61864 From https://github.com/nodejs/node * branch refs/pull/61864/merge -> FETCH_HEAD ✔ Fetched commits as c9acf345922b..30ff2f77f2af -------------------------------------------------------------------------------- [main 8f39ead20d] doc: support toolchain Visual Studio 2022 & 2026 + Windows 11 SDK Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Date: Tue Feb 17 12:01:32 2026 +0100 1 file changed, 5 insertions(+), 5 deletions(-) [main 261005c197] add back Windows 10 SDK Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Date: Wed Feb 18 17:47:01 2026 +0100 1 file changed, 5 insertions(+), 5 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:804) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc: support toolchain Visual Studio 2022 & 2026 + Windows 11 SDKhttps://github.com/nodejs/node/actions/runs/22266776680 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #61449
Situation
The Supported toolchains section of the
BUILDING.mddocument specifies:BUILDING.mddocument, the "Desktop development with C++" workload is required. In the older Visual Studio 2019, this installed the Windows 10 SDK. The Visual Studio 2022 & 2026 releases however install the Windows 11 SDK, not the Windows 10 SDK by default, although Visual Studio 2022 does allow optionally installing the (out-of-support) Windows 10 SDK.Change
Update the Supported toolchains section of the
BUILDING.mddocument to:This restricts the Visual Studio versions to the working ones, and adds Windows 11 SDK (which is the one currently supported by Microsoft) to the supported toolchain.
Backporting
This PR can be backported to v25.x with no restrictions
Backporting to v24.x requires the landing of PR [v24.x backport] build: add support for Visual Studio 2026 #61840 for consistency between documentation and capabilities, although backporting without the other PR won't make the documentation any more inaccurate than it currently is
Do not backport to v22.x or v20.x since they are not compatible with Visual Studio 2026 (see [v20.x] doc: supported toolchain with Visual Studio 2019 & 2022 only #61450 & [v22.x] doc: supported toolchain with Visual Studio 2022 only #61451 instead)